Fix: ensure this.outputPath/sourcePath trailing slash isn't removed (fixes #3675) #3676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-allen-89
requested review from
swashbuck,
taylortom,
joe-replin,
oliverfoster and
cahirodoherty-learningpool
taylortom
approved these changes
Apr 16, 2025
oliverfoster
approved these changes
Apr 16, 2025
lemmyadams
approved these changes
Apr 16, 2025
github-project-automation
bot
moved this from Needs Reviewing
to Recently Released
in adapt_framework: The TODO Board
|
🎉 This PR is included in version 5.46.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When changing from path.join to path.resolve the path is now being normalized and trailing slashes being removed.
#3675
Fix